Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add license title #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add license title #76

wants to merge 1 commit into from

Conversation

waldyrious
Copy link

It's not strictly required, but it's useful metadata, and part of the recommended license template text (see http://choosealicense.com/licenses/isc/ and https://opensource.org/licenses/isc-license)

@waldyrious
add license title
7559fc8 
It's not strictly required, but it's useful metadata, and part of the recommended license template text (see http://choosealicense.com/licenses/isc/ and https://opensource.org/licenses/isc-license)
@kylef
Copy link

kylef commented Sep 6, 2018 •
edited
Loading

@lloyd also package.json declares the license as MIT which isn't what the package is licensed (ISC):

"licenses": {
    "type": "MIT",
    "url": "https://raw.github.com/lloyd/JSONSelect/master/LICENSE"
}

This should become "licenses": "ISC" if updated, because the format of package.json deprecates the old object syntax in favour of SPDX identifiers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waldyrious @kylef